From 646a3ecbc540ef3dd4c9b17ef5312d8fd26c73eb Mon Sep 17 00:00:00 2001
From: twotalesanimation <80506065+twotalesanimation@users.noreply.github.com>
Date: Fri, 5 Dec 2025 11:46:24 +0200
Subject: [PATCH] fix: correct pricing calculations for non-members in
 bush_mechanics and rescue_recovery

---
 src/pages/bookings/driver_training.php | 34 +++++++++++++++++++-------
 src/pages/other/bush_mechanics.php     |  8 +++---
 src/pages/other/rescue_recovery.php    |  8 +++---
 3 files changed, 33 insertions(+), 17 deletions(-)

diff --git a/src/pages/bookings/driver_training.php b/src/pages/bookings/driver_training.php
index 9de4a244..eb546560 100644
--- a/src/pages/bookings/driver_training.php
+++ b/src/pages/bookings/driver_training.php
@@ -115,9 +115,8 @@ $page_id = 'driver_training';
                                         </select>
                                     </li>
                                         ';
-                                    } ?>
-
-                                    <li>
+                                        echo '
+                                        <li>
                                         Additional Non-Members <span class="price"></span>
                                         <select name="non-members" id="non-members">
                                             <option value="0" selected>00</option>
@@ -126,6 +125,23 @@ $page_id = 'driver_training';
                                             <option value="3">03</option>
                                         </select>
                                     </li>
+                                        ';
+                                    } else {
+                                        echo '
+                                        <li>
+                                        <small style="color: #666; display: block; margin-bottom: 5px;">You will be added at non-member rate</small>
+                                        Additional Participants <span class="price"></span>
+                                        <select name="non-members" id="non-members">
+                                            <option value="0" selected>00</option>
+                                            <option value="1">01</option>
+                                            <option value="2">02</option>
+                                            <option value="3">03</option>
+                                        </select>
+                                    </li>
+                                        ';
+                                    }
+                                    ?>
+
                                     
                                 </ul>
                                 <hr class="mb-25">
@@ -350,8 +366,8 @@ $page_id = 'driver_training';
         // Function to calculate booking total
         function calculateTotal() {
             // Get selected values from the form
-            var members = parseInt($('#members').val()) || 0; // Default to 1 vehicle if not selected
-            var nonmembers = parseInt($('#non-members').val()) || 0; // Default to 1 adult if not selected
+            var additional_members = parseInt($('#members').val()) || 0;
+            var additional_nonmembers = parseInt($('#non-members').val()) || 0;
 
             // Fetch PHP variables
             var isMember = <?php echo $is_member ? 'true' : 'false'; ?>;
@@ -362,12 +378,12 @@ $page_id = 'driver_training';
             // Calculate the total cost based on membership
             var total = 0;
 
-            // Calculate cost for members
+            // Calculate cost for members: (you at member rate) + additional members + additional non-members
             if (isMember || pendingMember) {
-                total = (cost_members) + (members * cost_members) + (nonmembers * cost_nonmembers);
+                total = (cost_members) + (additional_members * cost_members) + (additional_nonmembers * cost_nonmembers);
             } else {
-                // Calculate cost for non-members
-                total = (cost_nonmembers) + (members * cost_members) + (nonmembers * cost_nonmembers);
+                // Calculate cost for non-members: (you at non-member rate) + all additional people at non-member rate
+                total = (cost_nonmembers) + (additional_nonmembers * cost_nonmembers);
             }
 
             // Update total price in the DOM
diff --git a/src/pages/other/bush_mechanics.php b/src/pages/other/bush_mechanics.php
index 1f467372..431dfb86 100644
--- a/src/pages/other/bush_mechanics.php
+++ b/src/pages/other/bush_mechanics.php
@@ -346,8 +346,8 @@ $page_id = 'bush_mechanics';
         // Function to calculate booking total
         function calculateTotal() {
             // Get selected values from the form
-            var members = parseInt($('#members').val()) || 0; // Default to 1 vehicle if not selected
-            var nonmembers = parseInt($('#non-members').val()) || 0; // Default to 1 adult if not selected
+            var additional_members = parseInt($('#members').val()) || 0; // Default to 0 if not selected
+            var additional_nonmembers = parseInt($('#non-members').val()) || 0; // Default to 0 if not selected
 
             // Fetch PHP variables
             var isMember = <?php echo $is_member ? 'true' : 'false'; ?>;
@@ -360,10 +360,10 @@ $page_id = 'bush_mechanics';
 
             // Calculate cost for members
             if (isMember || pendingMember) {
-                total = (cost_members) + (members * cost_members) + (nonmembers * cost_nonmembers);
+                total = (cost_members) + (additional_members * cost_members) + (additional_nonmembers * cost_nonmembers);
             } else {
                 // Calculate cost for non-members
-                total = (cost_nonmembers) + (members * cost_members) + (nonmembers * cost_nonmembers);
+                total = (cost_nonmembers) + (additional_nonmembers * cost_nonmembers);
             }
 
             // Update total price in the DOM
diff --git a/src/pages/other/rescue_recovery.php b/src/pages/other/rescue_recovery.php
index 4ec650ac..85c12514 100644
--- a/src/pages/other/rescue_recovery.php
+++ b/src/pages/other/rescue_recovery.php
@@ -278,8 +278,8 @@ $page_id = 'rescue_recovery';
         // Function to calculate booking total
         function calculateTotal() {
             // Get selected values from the form
-            var members = parseInt($('#members').val()) || 0; // Default to 1 vehicle if not selected
-            var nonmembers = parseInt($('#non-members').val()) || 0; // Default to 1 adult if not selected
+            var additional_members = parseInt($('#members').val()) || 0; // Default to 0 if not selected
+            var additional_nonmembers = parseInt($('#non-members').val()) || 0; // Default to 0 if not selected
 
             // Fetch PHP variables
             var isMember = <?php echo $is_member ? 'true' : 'false'; ?>;
@@ -292,10 +292,10 @@ $page_id = 'rescue_recovery';
 
             // Calculate cost for members
             if (isMember || pendingMember) {
-                total = (cost_members) + (members * cost_members) + (nonmembers * cost_nonmembers);
+                total = (cost_members) + (additional_members * cost_members) + (additional_nonmembers * cost_nonmembers);
             } else {
                 // Calculate cost for non-members
-                total = (cost_nonmembers) + (members * cost_members) + (nonmembers * cost_nonmembers);
+                total = (cost_nonmembers) + (additional_nonmembers * cost_nonmembers);
             }
 
             // Update total price in the DOM