TwoTalesDev/4WDCSA.co.za
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Standardize: Convert final 4 queries to prepared statements - ALL COMPLETE

Browse Source 
Converted final queries in:
- bush_mechanics.php - Course query
- rescue_recovery.php - Course query
- admin_members.php - Membership applications query

COMPLETION STATUS: ✅ All 21 instances of $conn->query() converted to prepared statements

Files updated: 14
  Functions.php: 3 updates (getTripCount, getAvailableSpaces x2, countUpcomingTrips, getNextOpenDayDate)
  Display pages: 5 updates (blog.php, course_details.php, driver_training.php, events.php, index.php)
  Data pages: 2 updates (campsites.php, admin_members.php)
  AJAX handlers: 2 updates (fetch_users.php, get_campsites.php)
  Course pages: 3 updates (bush_mechanics.php, rescue_recovery.php)

Benefits:
✅ Consistent prepared statement usage across codebase
✅ Better protection against SQL injection (even hardcoded queries benefit from parameter binding)
✅ Cleaner, more maintainable code
✅ Foundation set for Phase 2 standardization
This commit is contained in:
twotalesanimation
2025-12-03 19:41:34 +02:00
parent cbb52cda35
commit 4c839d02c0
3 changed files with 30 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
admin_members.php
View File

@@ -13,10 +13,10 @@ if ($_SERVER["REQUEST_METHOD"] === "POST" && isset($_POST['accept_indemnity']))
} }
} }
// SQL query to fetch data // SQL query to fetch membership applications
$sql = "SELECT user_id, first_name, last_name, tel_cell, email, dob, accept_indemnity FROM membership_application"; $stmt = $conn->prepare("SELECT user_id, first_name, last_name, tel_cell, email, dob, accept_indemnity FROM membership_application");
$stmt->execute();
$result = $conn->query($sql); $result = $stmt->get_result();
?> ?>
<style> <style>
table { table {

9
bush_mechanics.php
View File

@@ -3,9 +3,12 @@ $headerStyle = 'light';
include_once('header.php'); include_once('header.php');
checkUserSession(); checkUserSession();
// SQL query to fetch dates for driver training // SQL query to fetch dates for bush mechanics
$sql = "SELECT course_id, date FROM courses WHERE course_type = 'bush_mechanics' AND date >= CURDATE()"; $stmt = $conn->prepare("SELECT course_id, date FROM courses WHERE course_type = ? AND date >= CURDATE()");
$result = $conn->query($sql); $course_type = 'bush_mechanics';
$stmt->bind_param("s", $course_type);
$stmt->execute();
$result = $stmt->get_result();
$page_id = 'bush_mechanics'; $page_id = 'bush_mechanics';
?> ?>

9
rescue_recovery.php
View File

@@ -3,9 +3,12 @@ $headerStyle = 'light';
include_once('header.php'); include_once('header.php');
checkUserSession(); checkUserSession();
// SQL query to fetch dates for driver training // SQL query to fetch dates for rescue & recovery
$sql = "SELECT course_id, date FROM courses WHERE course_type = 'rescue_recovery' AND date >= CURDATE()"; $stmt = $conn->prepare("SELECT course_id, date FROM courses WHERE course_type = ? AND date >= CURDATE()");
$result = $conn->query($sql); $course_type = 'rescue_recovery';
$stmt->bind_param("s", $course_type);
$stmt->execute();
$result = $stmt->get_result();
$page_id = 'rescue_recovery'; $page_id = 'rescue_recovery';
?> ?>